| Summary: | [LFC Display] Implement background bleed avoidance, and border-radius clipping of backgrounds | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2020-11-09 09:45:13 PST
Created attachment 413596 [details]
Patch
Comment on attachment 413596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413596&action=review > Source/WebCore/display/css/DisplayBoxDecorationData.cpp:122 > + if (edge.style() != BorderStyle::None && edge.width()) is it supposed to return true for BorderStyle::Hidden? Comment on attachment 413596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413596&action=review >> Source/WebCore/display/css/DisplayBoxDecorationData.cpp:122 >> + if (edge.style() != BorderStyle::None && edge.width()) > > is it supposed to return true for BorderStyle::Hidden? No, because hidden borders still takes space. This follows BorderValue::nonZero(). Committed r269601: <https://trac.webkit.org/changeset/269601> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413596 [details]. |