Bug 218713

Summary: [LFC Display] Implement background bleed avoidance, and border-radius clipping of backgrounds
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2020-11-09 09:45:13 PST
[LFC Display] Implement background bleed avoidance, and border-radius clipping of backgrounds
Attachments
Patch (59.03 KB, patch)
2020-11-09 09:47 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-11-09 09:47:45 PST
Created attachment 413596 [details] Patch
alan
Comment 2 2020-11-09 13:46:14 PST
Comment on attachment 413596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413596&action=review > Source/WebCore/display/css/DisplayBoxDecorationData.cpp:122 > + if (edge.style() != BorderStyle::None && edge.width()) is it supposed to return true for BorderStyle::Hidden?
Simon Fraser (smfr)
Comment 3 2020-11-09 13:52:06 PST
Comment on attachment 413596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413596&action=review >> Source/WebCore/display/css/DisplayBoxDecorationData.cpp:122 >> + if (edge.style() != BorderStyle::None && edge.width()) > > is it supposed to return true for BorderStyle::Hidden? No, because hidden borders still takes space. This follows BorderValue::nonZero().
EWS
Comment 4 2020-11-09 13:55:02 PST
Committed r269601: <https://trac.webkit.org/changeset/269601> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413596 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-09 13:56:33 PST
<rdar://problem/71209154>
Note You need to log in before you can comment on or make changes to this bug.