Bug 218713 - [LFC Display] Implement background bleed avoidance, and border-radius clipping of backgrounds
Summary: [LFC Display] Implement background bleed avoidance, and border-radius clippin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-09 09:45 PST by Simon Fraser (smfr)
Modified: 2020-11-09 13:56 PST (History)
4 users (show)

See Also:


Attachments
Patch (59.03 KB, patch)
2020-11-09 09:47 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-11-09 09:45:13 PST
[LFC Display] Implement background bleed avoidance, and border-radius clipping of backgrounds
Comment 1 Simon Fraser (smfr) 2020-11-09 09:47:45 PST
Created attachment 413596 [details]
Patch
Comment 2 zalan 2020-11-09 13:46:14 PST
Comment on attachment 413596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413596&action=review

> Source/WebCore/display/css/DisplayBoxDecorationData.cpp:122
> +        if (edge.style() != BorderStyle::None && edge.width())

is it supposed to return true for BorderStyle::Hidden?
Comment 3 Simon Fraser (smfr) 2020-11-09 13:52:06 PST
Comment on attachment 413596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413596&action=review

>> Source/WebCore/display/css/DisplayBoxDecorationData.cpp:122
>> +        if (edge.style() != BorderStyle::None && edge.width())
> 
> is it supposed to return true for BorderStyle::Hidden?

No, because hidden borders still takes space. This follows BorderValue::nonZero().
Comment 4 EWS 2020-11-09 13:55:02 PST
Committed r269601: <https://trac.webkit.org/changeset/269601>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413596 [details].
Comment 5 Radar WebKit Bug Importer 2020-11-09 13:56:33 PST
<rdar://problem/71209154>