Bug 218695

Summary:

Show legacy line layout visual coverage instead of "simple line" layout.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, sam, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description zalan 2020-11-08 16:13:08 PST

it's time to swap this.

Comment 1 zalan 2020-11-08 16:17:47 PST

Created attachment 413547 [details]
Patch

Comment 2 zalan 2020-11-09 12:13:02 PST

Created attachment 413616 [details]
Patch

Comment 3 zalan 2020-11-09 12:33:04 PST

Created attachment 413619 [details]
Patch

Comment 4 Sam Weinig 2020-11-09 12:40:23 PST

Comment on attachment 413619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413619&action=review

> Source/WTF/ChangeLog:8
> +        * Scripts/Preferences/WebPreferencesDebug.yaml:

I feel like maybe we should merge Debug and Internal preferences, as it seems silly to need to need to do all this plumbing to have the settings show up in minibrowser. Do you use the Debug nature of the setting (e.g. that it can be set globally for any WKWebView)?

Comment 5 Sam Weinig 2020-11-09 12:43:07 PST

Comment on attachment 413619 [details]
Patch

Antti r+'d this and bugzilla decided I meant to un-r+, which I didn't :( Sorry.

Comment 6 zalan 2020-11-09 13:01:08 PST

(In reply to Sam Weinig from comment #4)
> Comment on attachment 413619 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413619&action=review
> 
> > Source/WTF/ChangeLog:8
> > +        * Scripts/Preferences/WebPreferencesDebug.yaml:
> 
> I feel like maybe we should merge Debug and Internal preferences, as it
> seems silly to need to need to do all this plumbing to have the settings
> show up in minibrowser. Do you use the Debug nature of the setting (e.g.
> that it can be set globally for any WKWebView)?
I am fine with merging them.

Comment 7 EWS 2020-11-09 14:28:39 PST

Committed r269603: <https://trac.webkit.org/changeset/269603>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413619 [details].

Comment 8 Radar WebKit Bug Importer 2020-11-09 14:29:19 PST

<rdar://problem/71210962>

Comment 9 zalan 2020-11-09 14:54:28 PST

Reverted r269603 for reason:

Needs Safari patch

Committed r269605: <https://trac.webkit.org/changeset/269605>

Comment 10 zalan 2020-11-09 16:01:30 PST

(In reply to Sam Weinig from comment #4)
> Comment on attachment 413619 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413619&action=review
> 
> > Source/WTF/ChangeLog:8
> > +        * Scripts/Preferences/WebPreferencesDebug.yaml:
> 
> I feel like maybe we should merge Debug and Internal preferences, as it
> seems silly to need to need to do all this plumbing to have the settings
> show up in minibrowser. Do you use the Debug nature of the setting (e.g.
> that it can be set globally for any WKWebView)?
Actually let me do that instead.

Comment 11 zalan 2020-11-12 02:51:09 PST

Committed r269726: <https://trac.webkit.org/changeset/269726>