| Summary: | Implement the imperative slotting API | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annevk, chi187, emilio, mike, sam, tetsuharu.ohzeki, webkit-bug-importer, westbrook.johnson | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | Safari 12 | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 219261, 220768, 242376, 242379, 243460, 243634, 243635, 243649, 243654, 243655, 243772, 243815, 243817, 243860, 243867, 243869, 243923 | ||||||||||||||
| Bug Blocks: | 148695 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Ryosuke Niwa
2020-11-07 20:51:58 PST
May I take this? ———— When we start to implement this, should we add an experimental flag for this? (In reply to Tetsuharu Ohzeki [UTC+9] from comment #1) > May I take this? > > ———— > > When we start to implement this, should we add an experimental flag for this? You may! Please do! Yeah, adding an experimental flag to Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml would be a great thing to do for this. Please let us know if you have any questions. (If one of you could also do another pass over those PRs against DOM and HTML, perhaps after the latest round of feedback is addressed, that would be terrific. I'm afraid I'm starting to miss the bigger picture due to the long review cycles.) Created attachment 414807 [details]
wip
References: https://github.com/whatwg/html/pull/6561/files https://github.com/whatwg/dom/pull/966/files With this fully landed in Chrome and Firefox, any word on prioritization for bringing this to WebKit? Created attachment 453608 [details]
wip
Created attachment 453697 [details]
Alternative WIP
Created attachment 461478 [details]
WIP
Created attachment 461479 [details]
WIP
The most basic aspect of the feature works with this WIP.
(In reply to Ryosuke Niwa from comment #10) > Created attachment 461478 [details] > WIP hm... on my second thought, this approach doesn't quite work. I was trying to avoid having a dedicated back reference from a Node to its manually assigned slot but I don't think there is a way around it. When a slot that's outside "this" shadow tree is assigned of a node that had previously been assigned to another slot in "this" shadow tree, we still need to sever the slot assignment but we won't be able to find the slot without having some kind of a back reference from the node to its manually assigned slot. So we probably need a new member in NodeRareData which is about back reference from a Node to its manually assigned slot. It kind of stinks that we have to use NodeRareData for this. This feature is basically complete. We just need to enable it by default everywhere. Pull request: https://github.com/WebKit/WebKit/pull/3290 Committed 253402@main (80742bc96322): <https://commits.webkit.org/253402@main> Reviewed commits have been landed. Closing PR #3290 and removing active labels. |