Some .idl files generate code that is never built

• Component: WebCore JavaScript
• Status: NEW ---

[Greg Bolsinga]

SQLTransactionCallback.idl, SQLTransactionErrorCallback.idl, PositionCallback.idl, PositionErrorCallback.idl are a few of the examples David Kilzer and I noticed today.

The reason is that they have JSCustom* items and the handleEvent() method in these needs a bool& parameter.

Adding raises(DOMException) does not address this issue.

[David Kilzer (:ddkilzer)]

Basically, there should be a way to tell the generate-bindings.pl script (via CodeGeneratorJS.pm) that we don't want to create JS*.[cpp|h] files for these *.idl files.  Not sure if there is an existing "Custom" attribute that's missing, or if a new one needs to be added.

[David Kilzer (:ddkilzer)]

The GTK build may be broken until this is resolved:

DerivedSources/JSPositionCallback.cpp: In function 'JSC::JSValue* WebCore::jsPositionCallbackPrototypeFunctionHandleEvent(JSC::ExecState*, JSC::JSObject*, JSC::JSValue*, const JSC::ArgList&)':
DerivedSources/JSPositionCallback.cpp:145: error: no matching function for call to 'WebCore::PositionCallback::handleEvent(WebCore::Geoposition*&)'
/home/oe/webkit/source/WebKit-BuildSlave/trunk-gtk-linux-release/build/WebCore/page/PositionCallback.h:39: note: candidates are: virtual void WebCore::PositionCallback::handleEvent(WebCore::Geoposition*, bool&)

http://build.webkit.org/builders/trunk-gtk-linux-release/builds/1416

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> The GTK build may be broken until this is resolved:

Scratch that.  Fix coming (some *.idl shouldn't be included in GNUmakefile.am).

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (In reply to comment #2)
> > The GTK build may be broken until this is resolved:
> Scratch that.  Fix coming (some *.idl shouldn't be included in GNUmakefile.am).

See:  Bug 21475 Comment #27

[David Kilzer (:ddkilzer)]

See Bug 15406 for some shell scripts to find generated files that aren't included in Xcode projects.