Bug 218677

Summary:

Unexpose obsolete HTMLAppletElement interface

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, achristensen, annulen, apinheiro, berto, cfleizach, cgarcia, changseok, darin, d, dmazzoni, esprehn+autocc, ews-watchlist, ggaren, glenn, gustavo, gyuyoung.kim, japhet, jcraig, jdiggs, kondapallykalyan, mifenton, pdr, ryuan.choi, samuel_white, sam, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
WIP Patch	ews-feeder: commit-queue-
WIP Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2020-11-06 17:08:14 PST

Drop support for HTMLAppletElement. It has been dropped already from the HTML specification, from Blink and Gecko engines.

Attachments
WIP Patch (65.91 KB, patch) 2020-11-06 17:08 PST, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (9.61 KB, patch) 2020-11-09 08:59 PST, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (10.08 KB, patch) 2020-11-09 09:23 PST, Chris Dumez	no flags	Details Formatted Diff Diff
WIP Patch (15.06 KB, patch) 2020-11-09 09:57 PST, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP Patch (97.02 KB, patch) 2020-11-09 11:08 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (205.13 KB, patch) 2020-11-09 12:02 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (208.22 KB, patch) 2020-11-09 14:07 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (209.38 KB, patch) 2020-11-09 14:13 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (229.74 KB, patch) 2020-11-09 14:21 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2020-11-06 17:08:53 PST

Created attachment 413499 [details] WIP Patch

EWS Watchlist

Comment 2 2020-11-06 17:09:45 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Chris Dumez

Comment 3 2020-11-09 08:59:22 PST

Created attachment 413591 [details] WIP Patch

Chris Dumez

Comment 4 2020-11-09 09:23:21 PST

Created attachment 413595 [details] WIP Patch

Chris Dumez

Comment 5 2020-11-09 09:57:12 PST

Created attachment 413597 [details] WIP Patch

Chris Dumez

Comment 6 2020-11-09 11:08:57 PST

Created attachment 413603 [details] WIP Patch

Chris Dumez

Comment 7 2020-11-09 12:02:57 PST

Created attachment 413615 [details] Patch

Darin Adler

Comment 8 2020-11-09 13:36:17 PST

Comment on attachment 413615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413615&action=review I suspect there is a bit more that can be removed afterwards. > Source/WebCore/html/HTMLPlugInImageElement.h:32 > +// Base class for HTMLEmbedElement, and HTMLObjectElement. Should remove the "," here. > Source/WebCore/html/HTMLTagNames.in:11 > +applet interfaceName=HTMLUnknownElement Why do we need this? What is the benefit over just removing the tag name entirely instead? > Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLAppletElementPrivate.h:20 > #ifndef WebKitDOMHTMLAppletElementPrivate_h Seems like someone with enough knowledge of how things are used could remove this entire header instead. > Source/WebKitLegacy/mac/DOM/DOMHTMLAppletElement.mm:30 > #import <WebCore/HTMLNames.h> Can remove most of these includes, maybe all. > LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt:35 > APPLET also has: Should we change the test to remove this?

Chris Dumez

Comment 9 2020-11-09 13:40:43 PST

Comment on attachment 413615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413615&action=review >> Source/WebCore/html/HTMLTagNames.in:11 >> +applet interfaceName=HTMLUnknownElement > > Why do we need this? What is the benefit over just removing the tag name entirely instead? I tried what you suggested first but this was causing some WPT tests failures. Support for <applet> has not been removed at HTML parser level.

Chris Dumez

Comment 10 2020-11-09 14:07:08 PST

Created attachment 413631 [details] Patch

Chris Dumez

Comment 11 2020-11-09 14:13:42 PST

Created attachment 413632 [details] Patch

Geoffrey Garen

Comment 12 2020-11-09 14:16:25 PST

Relatedly, these files can be removed from the ManualTests folder: accessibility/java-applet.html accessibility/resources/AppletTest.java applet-finish-parsing-children.html applet-param-no-name.html java-string-object-type.html liveconnect-applet-array-parameters.html liveconnect-applet-get-boolean.html liveconnect-security-exception.html resources/DrawMessage.class resources/ArrayParameterTestApplet.class resources/liveconnect-security-exception-popup.html resources/CheckerApplet.java resources/ArrayParameterTestApplet.java resources/TestApplet.class resources/StringTypeTest.class resources/CheckerApplet.class resources/TestApplet.java resources/StringTypeTest.java

Chris Dumez

Comment 13 2020-11-09 14:21:02 PST

Created attachment 413634 [details] Patch

Chris Dumez

Comment 14 2020-11-09 14:21:37 PST

(In reply to Geoffrey Garen from comment #12) > Relatedly, these files can be removed from the ManualTests folder: > > accessibility/java-applet.html > accessibility/resources/AppletTest.java > applet-finish-parsing-children.html > applet-param-no-name.html > java-string-object-type.html > liveconnect-applet-array-parameters.html > liveconnect-applet-get-boolean.html > liveconnect-security-exception.html > resources/DrawMessage.class > resources/ArrayParameterTestApplet.class > resources/liveconnect-security-exception-popup.html > resources/CheckerApplet.java > resources/ArrayParameterTestApplet.java > resources/TestApplet.class > resources/StringTypeTest.class > resources/CheckerApplet.class > resources/TestApplet.java > resources/StringTypeTest.java Thanks, I dropped these too. I did not even know this folder existed :)

EWS

Comment 15 2020-11-09 16:29:30 PST

Committed r269612: <https://trac.webkit.org/changeset/269612> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413634 [details].

Radar WebKit Bug Importer

Comment 16 2020-11-09 16:30:21 PST

<rdar://problem/71216453>

Sam Sneddon [:gsnedders]

Comment 17 2022-07-05 13:57:43 PDT

*** Bug 157926 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.