Summary: | [Debug] imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.ellipse.basics.html is asserting | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | Canvas | Assignee: | Nikos Mouchtaris <nmouchtaris> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ahmad.saleem792, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, nmouchtaris, sabouhallawa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=218670 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2020-11-06 13:46:07 PST
Created attachment 413706 [details]
crash log
Created attachment 442719 [details]
Patch
Comment on attachment 442719 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442719&action=review > Source/WebCore/html/canvas/CanvasPath.cpp:148 > + ASSERT(newStartAngle >= 0 && (newStartAngle < 2 * piFloat || WTF::areEssentiallyEqual<float>(newStartAngle, 2 * piFloat))); Maybe we need an "approximately less than" helper? Created attachment 442727 [details]
Fix for test asserting
Committed r284996 (243642@main): <https://commits.webkit.org/243642@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442727 [details]. *** Bug 264367 has been marked as a duplicate of this bug. *** |