Bug 218669

Summary: Fix for LayoutTests/accessibility/Mac/accesskey.html in isolated tree mode.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2020-11-06 12:47:49 PST
Fix for LayoutTests/accessibility/Mac/accesskey.html in isolated tree mode.
Attachments
Patch (5.87 KB, patch)
2020-11-06 12:57 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (13.81 KB, patch)
2020-11-06 14:11 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-11-06 12:57:01 PST
Created attachment 413469 [details] Patch
chris fleizach
Comment 2 2020-11-06 13:03:01 PST
Comment on attachment 413469 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413469&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:203 > + setProperty(AXPropertyName::AccessKey, object.accessKey().isolatedCopy()); can you do a scan on the read of these and let's just update all to isolatedCopy that we need
Andres Gonzalez
Comment 3 2020-11-06 14:11:21 PST
Created attachment 413479 [details] Patch
Andres Gonzalez
Comment 4 2020-11-06 14:13:13 PST
(In reply to chris fleizach from comment #2) > Comment on attachment 413469 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413469&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:203 > > + setProperty(AXPropertyName::AccessKey, object.accessKey().isolatedCopy()); > > can you do a scan on the read of these and let's just update all to > isolatedCopy that we need Done.
EWS
Comment 5 2020-11-06 17:12:14 PST
Committed r269553: <https://trac.webkit.org/changeset/269553> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413479 [details].
Radar WebKit Bug Importer
Comment 6 2020-11-06 17:13:22 PST
<rdar://problem/71138788>
Note You need to log in before you can comment on or make changes to this bug.