| Summary: | Fix for LayoutTests/accessibility/Mac/accesskey.html in isolated tree mode. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2020-11-06 12:47:49 PST
Created attachment 413469 [details]
Patch
Comment on attachment 413469 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413469&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:203 > + setProperty(AXPropertyName::AccessKey, object.accessKey().isolatedCopy()); can you do a scan on the read of these and let's just update all to isolatedCopy that we need Created attachment 413479 [details]
Patch
(In reply to chris fleizach from comment #2) > Comment on attachment 413469 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413469&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:203 > > + setProperty(AXPropertyName::AccessKey, object.accessKey().isolatedCopy()); > > can you do a scan on the read of these and let's just update all to > isolatedCopy that we need Done. Committed r269553: <https://trac.webkit.org/changeset/269553> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413479 [details]. |