Bug 218669 - Fix for LayoutTests/accessibility/Mac/accesskey.html in isolated tree mode.
Summary: Fix for LayoutTests/accessibility/Mac/accesskey.html in isolated tree mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-06 12:47 PST by Andres Gonzalez
Modified: 2020-11-06 17:13 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.87 KB, patch)
2020-11-06 12:57 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (13.81 KB, patch)
2020-11-06 14:11 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-11-06 12:47:49 PST 
Fix for LayoutTests/accessibility/Mac/accesskey.html in isolated tree mode.
Comment 1 Andres Gonzalez 2020-11-06 12:57:01 PST 
Created attachment 413469 [details]
Patch
Comment 2 chris fleizach 2020-11-06 13:03:01 PST 
Comment on attachment 413469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413469&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:203
> +    setProperty(AXPropertyName::AccessKey, object.accessKey().isolatedCopy());

can you do a scan on the read of these and let's just update all to isolatedCopy that we need
Comment 3 Andres Gonzalez 2020-11-06 14:11:21 PST 
Created attachment 413479 [details]
Patch
Comment 4 Andres Gonzalez 2020-11-06 14:13:13 PST 
(In reply to chris fleizach from comment #2)
> Comment on attachment 413469 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413469&action=review
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:203
> > +    setProperty(AXPropertyName::AccessKey, object.accessKey().isolatedCopy());
> 
> can you do a scan on the read of these and let's just update all to
> isolatedCopy that we need

Done.
Comment 5 EWS 2020-11-06 17:12:14 PST 
Committed r269553: <https://trac.webkit.org/changeset/269553>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413479 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-06 17:13:22 PST 
<rdar://problem/71138788>