| Summary: | Further progress towards merging Settings.yaml into WebPreferences.yaml | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, cdumez, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2020-11-06 11:11:06 PST
Created attachment 413451 [details]
Patch
Created attachment 413459 [details]
Patch
Comment on attachment 413459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413459&action=review > Source/WTF/Scripts/Preferences/WebPreferences.yaml:1291 > "PLATFORM(IOS_FAMILY)": false Can we collapse down ones where it's the same in all three, or is that not a thing? (In reply to Tim Horton from comment #3) > Comment on attachment 413459 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413459&action=review > > > Source/WTF/Scripts/Preferences/WebPreferences.yaml:1291 > > "PLATFORM(IOS_FAMILY)": false > > Can we collapse down ones where it's the same in all three, or is that not a > thing? Not a thing at the moment. I decide to be very explicit for now. Once everything is there we can consider brevity though. Committed r269545: <https://trac.webkit.org/changeset/269545> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413459 [details]. |