Bug 218663

Summary: Further progress towards merging Settings.yaml into WebPreferences.yaml
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, darin, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Sam Weinig
Reported 2020-11-06 11:11:06 PST
Further progress towards merging Settings.yaml into WebPreferences.yaml
Attachments
Patch (36.09 KB, patch)
2020-11-06 11:28 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (37.66 KB, patch)
2020-11-06 12:07 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-11-06 11:28:49 PST
Created attachment 413451 [details] Patch
Sam Weinig
Comment 2 2020-11-06 12:07:11 PST
Created attachment 413459 [details] Patch
Tim Horton
Comment 3 2020-11-06 13:29:26 PST
Comment on attachment 413459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413459&action=review > Source/WTF/Scripts/Preferences/WebPreferences.yaml:1291 > "PLATFORM(IOS_FAMILY)": false Can we collapse down ones where it's the same in all three, or is that not a thing?
Sam Weinig
Comment 4 2020-11-06 15:12:40 PST
(In reply to Tim Horton from comment #3) > Comment on attachment 413459 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413459&action=review > > > Source/WTF/Scripts/Preferences/WebPreferences.yaml:1291 > > "PLATFORM(IOS_FAMILY)": false > > Can we collapse down ones where it's the same in all three, or is that not a > thing? Not a thing at the moment. I decide to be very explicit for now. Once everything is there we can consider brevity though.
EWS
Comment 5 2020-11-06 15:28:12 PST
Committed r269545: <https://trac.webkit.org/changeset/269545> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413459 [details].
Radar WebKit Bug Importer
Comment 6 2020-11-06 15:29:18 PST
<rdar://problem/71135486>
Note You need to log in before you can comment on or make changes to this bug.