| Summary: | Look at parents when event bubbles for input element activation behavior | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
| Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | changseok, clopez, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kangil.han, mifenton, rniwa, sam, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Dumez
2020-11-06 09:58:13 PST
Created attachment 413439 [details]
WIP Patch
Created attachment 413440 [details]
WIP Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 413461 [details]
Patch
Comment on attachment 413461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413461&action=review > Source/WebCore/dom/EventDispatcher.cpp:159 > + RefPtr<HTMLInputElement> input = is<HTMLInputElement>(node) ? &downcast<HTMLInputElement>(node) : nullptr; > + if (!input && event.type() == eventNames().clickEvent && event.bubbles()) > + input = findInputElementInEventPath(eventPath); To make the relationship with the spec language more clear, can we define a boolean called: isActivationEvent = event.type() == eventNames().clickEvent and input to something like inputWithLegacyPreActivationBehavior? Created attachment 413588 [details]
Patch
Committed r269582: <https://trac.webkit.org/changeset/269582> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413588 [details]. |