Bug 218660

Summary: Look at parents when event bubbles for input element activation behavior
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, clopez, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kangil.han, mifenton, rniwa, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
WIP Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-11-06 09:58:13 PST
Look at parents when event bubbles for input element activation behavior.
Attachments
WIP Patch (5.00 KB, patch)
2020-11-06 09:58 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (2.95 KB, patch)
2020-11-06 09:59 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2020-11-06 12:10 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.16 KB, patch)
2020-11-09 08:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-11-06 09:58:42 PST
Created attachment 413439 [details] WIP Patch
Chris Dumez
Comment 2 2020-11-06 09:59:22 PST
Created attachment 413440 [details] WIP Patch
EWS Watchlist
Comment 3 2020-11-06 09:59:39 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Chris Dumez
Comment 4 2020-11-06 12:10:58 PST
Created attachment 413461 [details] Patch
Ryosuke Niwa
Comment 5 2020-11-07 20:40:58 PST
Comment on attachment 413461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413461&action=review > Source/WebCore/dom/EventDispatcher.cpp:159 > + RefPtr<HTMLInputElement> input = is<HTMLInputElement>(node) ? &downcast<HTMLInputElement>(node) : nullptr; > + if (!input && event.type() == eventNames().clickEvent && event.bubbles()) > + input = findInputElementInEventPath(eventPath); To make the relationship with the spec language more clear, can we define a boolean called: isActivationEvent = event.type() == eventNames().clickEvent and input to something like inputWithLegacyPreActivationBehavior?
Chris Dumez
Comment 6 2020-11-09 08:43:15 PST
Created attachment 413588 [details] Patch
EWS
Comment 7 2020-11-09 09:27:05 PST
Committed r269582: <https://trac.webkit.org/changeset/269582> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413588 [details].
Radar WebKit Bug Importer
Comment 8 2020-11-09 09:28:20 PST
<rdar://problem/71195341>
Note You need to log in before you can comment on or make changes to this bug.