Bug 218657

Summary: [macOS] Add IOKIt message filtering
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch none

Description Per Arne Vollan 2020-11-06 07:23:14 PST 
Like on iOS, the WebContent process on macOS should have IOKit message filtering as well.
Comment 1 Radar WebKit Bug Importer 2020-11-06 07:23:33 PST 
<rdar://problem/71118545>
Comment 2 Per Arne Vollan 2020-11-06 07:45:13 PST 
Created attachment 413430 [details]
Patch
Comment 3 Per Arne Vollan 2020-11-06 12:21:50 PST 
Created attachment 413463 [details]
Patch
Comment 4 Per Arne Vollan 2020-11-06 12:27:11 PST 
Created attachment 413465 [details]
Patch
Comment 5 Brent Fulgham 2020-11-06 12:44:11 PST 
Comment on attachment 413465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413465&action=review

I had a few questions, but looks good. r=me

> Source/WebKit/ChangeLog:9
> +        Like on iOS, the WebContent process on macOS should have IOKit message filtering as well.

No need for "as well" at the end (since you say "Like on iOS, ...")

> Source/WebKit/ChangeLog:15
> +        * WebProcess/com.apple.WebProcess.sb.in:

Should we be making similar changes to the GPU Process sandbox?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-139
> -        (iokit-registry-entry-class "AppleGraphicsControlClient")

So we do NOT need AppleGraphicsControlClient?
Comment 6 Per Arne Vollan 2020-11-06 12:59:37 PST 
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 413465 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413465&action=review
> 
> I had a few questions, but looks good. r=me
> 
> > Source/WebKit/ChangeLog:9
> > +        Like on iOS, the WebContent process on macOS should have IOKit message filtering as well.
> 
> No need for "as well" at the end (since you say "Like on iOS, ...")
> 

Will fix!

> > Source/WebKit/ChangeLog:15
> > +        * WebProcess/com.apple.WebProcess.sb.in:
> 
> Should we be making similar changes to the GPU Process sandbox?
> 

That is a good point. Would you be OK with doing this in a separate patch?

> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-139
> > -        (iokit-registry-entry-class "AppleGraphicsControlClient")
> 
> So we do NOT need AppleGraphicsControlClient?

Ah, good catch! Will fix.

Thanks for reviewing!
Comment 7 Per Arne Vollan 2020-11-06 13:09:55 PST 
Created attachment 413472 [details]
Patch
Comment 8 EWS 2020-11-06 16:32:11 PST 
Committed r269550: <https://trac.webkit.org/changeset/269550>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413472 [details].