Bug 218640 – Do not allow pages to enter fullscreen while an exit fullscreen operation is ongoing.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Do not allow pages to enter fullscreen while an exit fullscreen operation is ongoing.

[Jer Noble]

<rdar://problem/70697738>

[Jer Noble]

Created attachment 413378 [details]
Patch

[Peng Liu]

Comment on attachment 413378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413378&action=review

> LayoutTests/fullscreen/full-screen-enter-while-exiting.html:16
> +            logResult(false, "This test requires Internals.");

Nit. Is the error message correct?

> LayoutTests/fullscreen/full-screen-enter-while-exiting.html:22
> +            logResult(false, "This test requires WebKitTestRunner.")

Ditto.

[Jer Noble]

(In reply to Peng Liu from comment #3)
> Comment on attachment 413378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413378&action=review
> 
> > LayoutTests/fullscreen/full-screen-enter-while-exiting.html:16
> > +            logResult(false, "This test requires Internals.");
> 
> Nit. Is the error message correct?

Yes; it's shorthand for having both window.testRunner and window.internals, both of which are required for this test.

> > LayoutTests/fullscreen/full-screen-enter-while-exiting.html:22
> > +            logResult(false, "This test requires WebKitTestRunner.")
> 
> Ditto.

Yes; the callback methods have only been implemented in WKTR.

[EWS]

Committed r269522: <https://trac.webkit.org/changeset/269522>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413378 [details].