| Summary: | Do not allow pages to enter fullscreen while an exit fullscreen operation is ongoing. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, eric.carlson, esprehn+autocc, ews-watchlist, kangil.han, peng.liu6, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jer Noble
2020-11-05 17:20:45 PST
Created attachment 413378 [details]
Patch
Comment on attachment 413378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413378&action=review > LayoutTests/fullscreen/full-screen-enter-while-exiting.html:16 > + logResult(false, "This test requires Internals."); Nit. Is the error message correct? > LayoutTests/fullscreen/full-screen-enter-while-exiting.html:22 > + logResult(false, "This test requires WebKitTestRunner.") Ditto. (In reply to Peng Liu from comment #3) > Comment on attachment 413378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413378&action=review > > > LayoutTests/fullscreen/full-screen-enter-while-exiting.html:16 > > + logResult(false, "This test requires Internals."); > > Nit. Is the error message correct? Yes; it's shorthand for having both window.testRunner and window.internals, both of which are required for this test. > > LayoutTests/fullscreen/full-screen-enter-while-exiting.html:22 > > + logResult(false, "This test requires WebKitTestRunner.") > > Ditto. Yes; the callback methods have only been implemented in WKTR. Committed r269522: <https://trac.webkit.org/changeset/269522> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413378 [details]. |