Bug 218640 - Do not allow pages to enter fullscreen while an exit fullscreen operation is ongoing.
Summary: Do not allow pages to enter fullscreen while an exit fullscreen operation is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-05 17:20 PST by Jer Noble
Modified: 2020-11-06 10:33 PST (History)
7 users (show)

See Also:


Attachments
Patch (14.39 KB, patch)
2020-11-05 17:25 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-11-05 17:20:45 PST
Do not allow pages to enter fullscreen while an exit fullscreen operation is ongoing.
Comment 1 Jer Noble 2020-11-05 17:21:27 PST
<rdar://problem/70697738>
Comment 2 Jer Noble 2020-11-05 17:25:12 PST
Created attachment 413378 [details]
Patch
Comment 3 Peng Liu 2020-11-05 17:34:55 PST
Comment on attachment 413378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413378&action=review

> LayoutTests/fullscreen/full-screen-enter-while-exiting.html:16
> +            logResult(false, "This test requires Internals.");

Nit. Is the error message correct?

> LayoutTests/fullscreen/full-screen-enter-while-exiting.html:22
> +            logResult(false, "This test requires WebKitTestRunner.")

Ditto.
Comment 4 Jer Noble 2020-11-05 22:59:27 PST
(In reply to Peng Liu from comment #3)
> Comment on attachment 413378 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=413378&action=review
> 
> > LayoutTests/fullscreen/full-screen-enter-while-exiting.html:16
> > +            logResult(false, "This test requires Internals.");
> 
> Nit. Is the error message correct?

Yes; it's shorthand for having both window.testRunner and window.internals, both of which are required for this test.

> > LayoutTests/fullscreen/full-screen-enter-while-exiting.html:22
> > +            logResult(false, "This test requires WebKitTestRunner.")
> 
> Ditto.

Yes; the callback methods have only been implemented in WKTR.
Comment 5 EWS 2020-11-06 10:33:31 PST
Committed r269522: <https://trac.webkit.org/changeset/269522>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413378 [details].