| Summary: | Add userData() and setUserData() methods to QWebHistoryItem. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yael <yael> | ||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | beidson, darin, hausmann | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | 21863 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Yael
2008-10-24 13:48:21 PDT
Created attachment 24652 [details]
Add new API
Add new API.
Why is this separate from bug 21863? It would be clearer to have a single patch for review than these two patches. (In reply to comment #2) > Why is this separate from bug 21863? It would be clearer to have a single patch > for review than these two patches. > Sorry for the confusion. I was told that it is easier to review patches if they are broken into smaller chunks. If that's not the case, I will not break my patches in the future. thanks! (In reply to comment #3) > Sorry for the confusion. I was told that it is easier to review patches if they > are broken into smaller chunks. If that's not the case, I will not break my > patches in the future. thanks! That is indeed true in general. But in this case, the chunks don't have any good logical separation -- there's just a lower level machinery that's unused and then adding the API to get at it. Please don't take this as a general push to make patches larger in the future! It's good to break things up into the smallest sensible chunks that you can. Comment on attachment 24652 [details]
Add new API
Looks good! I'll do a few small cleanups before applying.
|