Bug 218631

Summary:

DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, hi, kangil.han, kondapallykalyan, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Chris Dumez

Reported 2020-11-05 11:45:43 PST

DOMStringList, TextMetrics & ImageBitmapRenderingContext should be exposed to workers: - https://html.spec.whatwg.org/multipage/common-dom-interfaces.html#domstringlist - https://html.spec.whatwg.org/multipage/canvas.html#textmetrics - https://html.spec.whatwg.org/multipage/canvas.html#imagebitmaprenderingcontext

Attachments
Patch (14.94 KB, patch) 2020-11-05 11:47 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (16.09 KB, patch) 2020-11-05 13:24 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2020-11-05 11:47:50 PST

Created attachment 413336 [details] Patch

Chris Dumez

Comment 2 2020-11-05 13:24:46 PST

Created attachment 413347 [details] Patch

Geoffrey Garen

Comment 3 2020-11-05 13:31:00 PST

Comment on attachment 413347 [details] Patch How does ImageBitmapRenderingContext.canvas work on a worker? Is it always null? Do we have any tests that exercise ImageBitmapRenderingContext in more detail on a worker?

Chris Dumez

Comment 4 2020-11-05 13:36:24 PST

(In reply to Geoffrey Garen from comment #3) > Comment on attachment 413347 [details] > Patch > > How does ImageBitmapRenderingContext.canvas work on a worker? Is it always > null? > > Do we have any tests that exercise ImageBitmapRenderingContext in more > detail on a worker? To be clear, this patch is not about exposing a particular functionality to workers. It merely exposes properties on the global WorkerGlobalScope. To answer your question about ImageBitmapRenderingContext.canvas (although not really in the scope of this patch), the property can return either an HTMLCanvasElement or an OffscreenCanvas. In the case of workers, it would return an OffscreenCanvas. There is an implementation of OffscreenCanvas in WebKit but as far as I know is not enabled for Apple ports yet (not sure if the feature is complete or not).

EWS

Comment 5 2020-11-05 14:39:46 PST

Committed r269476: <https://trac.webkit.org/changeset/269476> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413347 [details].

Radar WebKit Bug Importer

Comment 6 2020-11-05 14:40:20 PST

<rdar://problem/71095192>

Note You need to log in before you can comment on or make changes to this bug.