Bug 218624

Summary: Change RELEASE_ASSERT to use branch+crash inside HashTable.h
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing none

Saam Barati
Reported 2020-11-05 10:39:15 PST
...
Attachments
patch (2.88 KB, patch)
2020-11-05 10:56 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (3.26 KB, patch)
2020-11-05 11:12 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2020-11-05 10:42:27 PST
<rdar://problem/70901101>
Saam Barati
Comment 2 2020-11-05 10:56:36 PST
Created attachment 413324 [details] patch
Mark Lam
Comment 3 2020-11-05 11:02:55 PST
Comment on attachment 413324 [details] patch r=me. Can you introduce a HASH_TABLE_ASSERT macro to encapsulate this instead? You can #undef it at the end of the file.
Mark Lam
Comment 4 2020-11-05 11:03:28 PST
/HASH_TABLE_ASSERT/HASH_TABLE_RELEASE_ASSERT/
Saam Barati
Comment 5 2020-11-05 11:12:02 PST
Created attachment 413328 [details] patch for landing
EWS
Comment 6 2020-11-05 15:02:46 PST
Committed r269478: <https://trac.webkit.org/changeset/269478> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413328 [details].
Note You need to log in before you can comment on or make changes to this bug.