Bug 218613

Summary: Enable llint asm on aarch64 when USE(64KB_PAGE_BLOCK) is enabled
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, clopez, ews-watchlist, gyuyoung.kim, mcatanzaro, mgorse, ryuan.choi, sergio, xan.lopez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217989
https://bugs.webkit.org/show_bug.cgi?id=219288
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2020-11-05 06:14:53 PST
Bug #217989 forces cloop when USE(64KB_PAGE_BLOCK) is enabled. Xan recommends we use llint's assembler backend instead, since it is faster and bugs should be rare.
Attachments
Patch (1.92 KB, patch)
2020-11-05 06:46 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-11-05 06:46:55 PST
Created attachment 413291 [details] Patch
Michael Catanzaro
Comment 2 2020-11-05 07:38:05 PST
(Mike: this reverses my previous recommendation that we should use cloop on aarch64.)
EWS
Comment 3 2020-11-09 10:53:54 PST
Committed r269586: <https://trac.webkit.org/changeset/269586> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413291 [details].
Michael Catanzaro
Comment 4 2020-11-25 14:36:40 PST
This doesn't build. Turns out aarch64 llint depends on JIT due to USE(JUMP_ISLANDS). It seems this configuration is maybe not as well-tested as we had hoped? Let's follow-up in bug #219288.
Note You need to log in before you can comment on or make changes to this bug.