Bug 218580

Summary: [GStreamer] fast/mediastream/captureStream/canvas2d.html is flaky timing out since GStreamer 1.18 update
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: MediaAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, dpino, eric.carlson, ews-watchlist, fjimenez, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222451
Attachments:
Description Flags
Tentative example
none
Patch none

Lauro Moura
Reported 2020-11-04 11:53:57 PST
fast/mediastream/captureStream/canvas2d.html Marked as flaky Pass/Fail in root expectations, it's timing out in GLib platforms, especially in Release/Wayland platforms (WPE-Release and GTK-Wayland-Release bots). When current spell of flaky timeouts started: WPE-Release: r267140 GTK-Wayland: r267141 GTK-Debug: r267156 GTK-Release: r267241 WPE-Debug: r268715 Revisions r267138 through r267140 were related to the GStreamer 1.18 update in the new SDK version. At least in WPE-Release, it seems to be getting stuck in the `canvas2.getContext("2d").drawImage(video, 0 ,0);` call. Link to results history: https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediastream%2FcaptureStream%2Fcanvas2d.html
Attachments
Tentative example (1.10 KB, text/html)
2020-11-04 11:55 PST, Lauro Moura 		no flags
Details
Patch (5.96 KB, patch)
2021-02-22 08:26 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-11-04 11:55:39 PST
Created attachment 413192 [details] Tentative example This is a sample html test case likely related to the root issue, with the canvas1 -> video -> canvas2 pipeline drawing the canvas. Works on firefox, but does not draw canvas2 in GTK/WPE ToT (although it does not get stuck like in the test).
Philippe Normand
Comment 2 2021-02-22 00:49:41 PST
Looks like we emit the play event before the first video frame reached the sink, that's why the canvas sourcing from the video element is empty in that test-case.
Philippe Normand
Comment 3 2021-02-22 08:26:54 PST
Created attachment 421194 [details] Patch
Philippe Normand
Comment 4 2021-02-22 08:28:09 PST
*** Bug 217829 has been marked as a duplicate of this bug. ***
EWS
Comment 5 2021-02-23 08:58:21 PST
Committed r273309: <https://commits.webkit.org/r273309> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421194 [details].
Radar WebKit Bug Importer
Comment 6 2021-02-23 08:59:14 PST
<rdar://problem/74644074>
Note You need to log in before you can comment on or make changes to this bug.