Bug 218565

Summary:

[css-grid] Move tests grid-columns-rows-get-set-multiple and grid-content-sized-columns-resolution to WPT folder

Product:

WebKit

Reporter:

zsun

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, ews-watchlist, jfernandez, rego, svillar, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

zsun

Reported 2020-11-04 07:14:28 PST

This patch moves the following tests * grid-columns-rows-get-set-multiple.html * grid-content-sized-columns-resolution.html to WPT folder and removes their corresponding outdated versions from css-grid-layout folder

Attachments
Patch (94.99 KB, patch) 2020-11-05 01:57 PST, zsun	no flags	Details Formatted Diff Diff
Patch (94.99 KB, patch) 2020-11-05 02:01 PST, zsun	no flags	Details Formatted Diff Diff
Patch (96.22 KB, patch) 2020-11-05 02:35 PST, zsun	no flags	Details Formatted Diff Diff
Patch (96.56 KB, patch) 2020-11-05 03:01 PST, zsun	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

zsun

Comment 1 2020-11-05 01:57:45 PST

Created attachment 413273 [details] Patch

EWS Watchlist

Comment 2 2020-11-05 01:58:58 PST

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

zsun

Comment 3 2020-11-05 02:01:40 PST

Created attachment 413274 [details] Patch

Manuel Rego Casasnovas

Comment 4 2020-11-05 02:10:22 PST

Comment on attachment 413274 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413274&action=review Thanks for doing this, just a minor change is required, the rest looks good to me. > LayoutTests/ChangeLog:7 > + I'd add here a small comment, explaining that these tests have been moved upstream in a Chromium change, linking the change or the WPT PR generated by the change. > LayoutTests/imported/w3c/ChangeLog:12 > + I believe we miss a change in "css/css-grid/parsing/w3c-import.log" to include the new tests.

zsun

Comment 5 2020-11-05 02:31:34 PST

These changes have been moved upstream in Chromium (https://chromium-review.googlesource.com/c/chromium/src/+/2436821) and ported in WPT (https://github.com/web-platform-tests/wpt/commit/7a287c9e26fbc12c91e1dde91859fabed96254b6)

zsun

Comment 6 2020-11-05 02:35:12 PST

Created attachment 413278 [details] Patch

zsun

Comment 7 2020-11-05 03:01:57 PST

Created attachment 413280 [details] Patch

Manuel Rego Casasnovas

Comment 8 2020-11-05 03:06:57 PST

Comment on attachment 413280 [details] Patch r=me, thanks! Let's wait for the EWSs to be green before landing.