Summary: | libwebrtc.dylib relies on dead code stripping (fails to link if dead code is not stripped in Debug builds) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=218315 | ||||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2020-11-02 10:49:10 PST
What is the build instruction to trigger that issue? (In reply to youenn fablet from comment #1) > What is the build instruction to trigger that issue? Rough steps to reproduce (I didn't try): 1. Apply patch from Bug 218315. 2. In Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig, change "DEAD_CODE_STRIPPING = YES" to "DEAD_CODE_STRIPPING = NO": // FIXME: Bug 218453: libwebrtc.dylib fails to link if this value is changed in libwebrtc.xcconfig or changed here for all targets. - DEAD_CODE_STRIPPING = YES; + DEAD_CODE_STRIPPING = NO; 3. Build Release or Debug. (I don't think it matters which if "DEAD_CODE_STRIPPING = NO" for both.) (In reply to David Kilzer (:ddkilzer) from comment #2) > (In reply to youenn fablet from comment #1) > > What is the build instruction to trigger that issue? > > Rough steps to reproduce (I didn't try): Specifically, this is how I reproduced it while working on Bug 218315, but I did not try it again before posting this info. Thanks, we are probably missing some files that are only used by code that got stripped. Hopefully, we just need to compile this missing files. Created attachment 413144 [details]
Patch
Created attachment 414920 [details]
Patch
Created attachment 414926 [details]
Patch
Ping review Committed r270305: <https://trac.webkit.org/changeset/270305> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414926 [details]. Thanks Youenn! |