Bug 218451

Summary: [CMake] Add remote inspector platforms
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bburg, ews-watchlist, gyuyoung.kim, hi, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, stephan.szabo, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Don Olmstead
Reported 2020-11-02 09:48:00 PST
Centralize the different remote inspector platform configs.
Attachments
Patch (13.58 KB, patch)
2020-11-02 09:59 PST, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.58 KB, patch)
2020-11-02 10:05 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (16.23 KB, patch)
2020-11-02 11:06 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-11-02 09:59:58 PST Comment hidden (obsolete)
Don Olmstead
Comment 2 2020-11-02 10:05:07 PST
Created attachment 412937 [details] Patch
Stephan Szabo
Comment 3 2020-11-02 10:25:56 PST
Comment on attachment 412937 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412937&action=review > Source/JavaScriptCore/PlatformJSCOnly.cmake:5 > + include(inspector/remote/GLib.cmake) It seems like this wouldn't end up with the same set of sources as before as the SourcesGTK.txt has more things (for example RemoteAutomationTarget.cpp). Is that okay?
Don Olmstead
Comment 4 2020-11-02 10:34:57 PST
(In reply to Stephan Szabo from comment #3) > Comment on attachment 412937 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412937&action=review > > > Source/JavaScriptCore/PlatformJSCOnly.cmake:5 > > + include(inspector/remote/GLib.cmake) > > It seems like this wouldn't end up with the same set of sources as before as > the SourcesGTK.txt has more things (for example RemoteAutomationTarget.cpp). > Is that okay? I'm not sure how well the JSCOnly with USE_GLIB is maintained. I don't think it would be an issue. Also not sure about JSCOnly on Cocoa and if there should be a Cocoa.cmake for it and Mac.
Don Olmstead
Comment 5 2020-11-02 11:06:54 PST
Created attachment 412948 [details] Patch Add a Cocoa platform definition for JSCOnly.
EWS
Comment 6 2020-11-03 09:37:47 PST
Committed r269309: <https://trac.webkit.org/changeset/269309> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412948 [details].
Blaze Burg
Comment 7 2021-01-26 10:22:12 PST
Comment on attachment 412948 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412948&action=review > Source/JavaScriptCore/PlatformFTW.cmake:31 > + include(inpsector/remote/Socket.cmake) This looks incorrect (typo). How come EWS is all green, do we build FTW in CI somewhere?
Don Olmstead
Comment 8 2021-01-26 12:58:01 PST
(In reply to BJ Burg from comment #7) > Comment on attachment 412948 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412948&action=review > > > Source/JavaScriptCore/PlatformFTW.cmake:31 > > + include(inpsector/remote/Socket.cmake) > > This looks incorrect (typo). How come EWS is all green, do we build FTW in > CI somewhere? Yea that's a typo. The FTW port doesn't build currently so I'll add that in there while fixing.
Note You need to log in before you can comment on or make changes to this bug.