Bug 218447

Summary: [Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa)
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Sam Weinig
Reported 2020-11-02 08:56:06 PST
[Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa)
Attachments
Patch (3.32 KB, patch)
2020-11-02 09:01 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (6.86 KB, patch)
2020-11-02 09:58 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (7.12 KB, patch)
2020-11-02 10:43 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (7.94 KB, patch)
2020-11-02 10:59 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (12.72 KB, patch)
2020-11-02 11:53 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.37 KB, patch)
2020-11-02 12:10 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (14.07 KB, patch)
2020-11-02 13:21 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-11-02 09:01:15 PST Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-11-02 09:58:54 PST Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-11-02 10:43:19 PST Comment hidden (obsolete)
Sam Weinig
Comment 4 2020-11-02 10:59:35 PST Comment hidden (obsolete)
Sam Weinig
Comment 5 2020-11-02 11:53:28 PST Comment hidden (obsolete)
Sam Weinig
Comment 6 2020-11-02 12:10:16 PST
Created attachment 412958 [details] Patch
Sam Weinig
Comment 7 2020-11-02 13:21:52 PST
Created attachment 412963 [details] Patch
Darin Adler
Comment 8 2020-11-02 14:56:24 PST
Comment on attachment 412963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412963&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:901 > + [preferences setEncryptedMediaAPIEnabled:YES]; > + [preferences setGamepadsEnabled:YES]; > + [preferences setLinkPreloadEnabled:YES]; > + [preferences setMediaPreloadingEnabled:YES]; > + [preferences setColorFilterEnabled:YES]; What’s the significance of the ordering here? If there’s none, then I suggest sorting.
EWS
Comment 9 2020-11-02 16:05:25 PST
Committed r269278: <https://trac.webkit.org/changeset/269278> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412963 [details].
Radar WebKit Bug Importer
Comment 10 2020-11-02 16:06:52 PST
<rdar://problem/70970524>
Sam Weinig
Comment 11 2020-11-02 16:10:04 PST
(In reply to Darin Adler from comment #8) > Comment on attachment 412963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412963&action=review > > > Tools/DumpRenderTree/mac/DumpRenderTree.mm:901 > > + [preferences setEncryptedMediaAPIEnabled:YES]; > > + [preferences setGamepadsEnabled:YES]; > > + [preferences setLinkPreloadEnabled:YES]; > > + [preferences setMediaPreloadingEnabled:YES]; > > + [preferences setColorFilterEnabled:YES]; > > What’s the significance of the ordering here? If there’s none, then I > suggest sorting. There was none. Put a patch up to sort everything in the function at https://bugs.webkit.org/show_bug.cgi?id=218467.
Note You need to log in before you can comment on or make changes to this bug.