Bug 218442

Summary: Allow low latency H264 encoder in GPUProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218445    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

youenn fablet
Reported 2020-11-02 05:56:04 PST
Allow low latency H264 encoder in GPUProcess
Attachments
Patch (37.85 KB, patch)
2020-11-02 06:01 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (37.92 KB, patch)
2020-11-02 06:37 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.91 KB, patch)
2020-11-03 03:19 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.91 KB, patch)
2020-11-03 03:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-11-02 06:01:50 PST
Created attachment 412909 [details] Patch
youenn fablet
Comment 2 2020-11-02 06:37:55 PST
Created attachment 412914 [details] Patch
Eric Carlson
Comment 3 2020-11-02 14:03:58 PST
Comment on attachment 412914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412914&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:97 > +- (void)setLowLatency:(bool)isLowLatencyEnabled { Nit: "isLowLatencyEnabled" sounds like a question, I would probably call the parameter "lowLatencyEnabled", or even just "enabled" > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:99 > + return [m_h264Encoder setH264LowLatencyEncoderEnabled:isLowLatencyEnabled]; Nit: "return" is unnecessary > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:319 > +void setLocalEncoderLowLatency(LocalEncoder localEncoder, bool isLowLatencyEnabled) Ditto about the parameter name from above.
youenn fablet
Comment 4 2020-11-03 03:19:15 PST
Created attachment 413032 [details] Patch for landing
EWS
Comment 5 2020-11-03 03:55:39 PST
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.
youenn fablet
Comment 6 2020-11-03 03:57:52 PST
Created attachment 413039 [details] Patch for landing
EWS
Comment 7 2020-11-03 04:33:08 PST
Committed r269293: <https://trac.webkit.org/changeset/269293> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413039 [details].
Radar WebKit Bug Importer
Comment 8 2020-11-03 04:34:19 PST
<rdar://problem/70989701>
Note You need to log in before you can comment on or make changes to this bug.