| Summary: | Allow low latency H264 encoder in GPUProcess | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 218445 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2020-11-02 05:56:04 PST
Created attachment 412909 [details]
Patch
Created attachment 412914 [details]
Patch
Comment on attachment 412914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412914&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:97 > +- (void)setLowLatency:(bool)isLowLatencyEnabled { Nit: "isLowLatencyEnabled" sounds like a question, I would probably call the parameter "lowLatencyEnabled", or even just "enabled" > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:99 > + return [m_h264Encoder setH264LowLatencyEncoderEnabled:isLowLatencyEnabled]; Nit: "return" is unnecessary > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitEncoder.mm:319 > +void setLocalEncoderLowLatency(LocalEncoder localEncoder, bool isLowLatencyEnabled) Ditto about the parameter name from above. Created attachment 413032 [details]
Patch for landing
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!. Created attachment 413039 [details]
Patch for landing
Committed r269293: <https://trac.webkit.org/changeset/269293> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413039 [details]. |