Bug 218374

Summary: Convert ScrollingTreeNode change flags to an OptionSet<>
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ddkilzer, ews-watchlist, fred.wang, jamesr, koivisto, luiz, sam, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2020-10-29 22:23:00 PDT
Convert ScrollingTreeNode change flags to an OptionSet<>
Attachments
Patch (143.37 KB, patch)
2020-10-29 22:23 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (154.19 KB, patch)
2020-10-29 22:32 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-10-29 22:23:55 PDT
Created attachment 412713 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-10-29 22:32:00 PDT
Created attachment 412715 [details] Patch
Antti Koivisto
Comment 3 2020-10-29 22:37:02 PDT
Comment on attachment 412715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412715&action=review > Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:110 > +template<> struct EnumTraits<WebCore::ScrollingStateNode::Property> { > + using values = EnumValues< > + WebCore::ScrollingStateNode::Property, > + WebCore::ScrollingStateNode::Property::Layer, > + WebCore::ScrollingStateNode::Property::ChildNodes, > + WebCore::ScrollingStateNode::Property::ScrollableAreaSize, Sad that this thing has to list all values again. Does it at least fail at compile time if you miss something?
Simon Fraser (smfr)
Comment 4 2020-10-29 22:57:14 PDT
(In reply to Antti Koivisto from comment #3) > Comment on attachment 412715 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412715&action=review > > > Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:110 > > +template<> struct EnumTraits<WebCore::ScrollingStateNode::Property> { > > + using values = EnumValues< > > + WebCore::ScrollingStateNode::Property, > > + WebCore::ScrollingStateNode::Property::Layer, > > + WebCore::ScrollingStateNode::Property::ChildNodes, > > + WebCore::ScrollingStateNode::Property::ScrollableAreaSize, > > Sad that this thing has to list all values again. Does it at least fail at > compile time if you miss something? It does compile but I assume IPC decoding would throw a failure at runtime. Not ideal.
EWS
Comment 5 2020-10-30 06:59:26 PDT
Committed r269184: <https://trac.webkit.org/changeset/269184> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412715 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-30 07:00:25 PDT
<rdar://problem/70873217>
Note You need to log in before you can comment on or make changes to this bug.