| Summary: | Convert ScrollingTreeNode change flags to an OptionSet<> | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, ddkilzer, ews-watchlist, fred.wang, jamesr, koivisto, luiz, sam, simon.fraser, tonikitoo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2020-10-29 22:23:00 PDT
Created attachment 412713 [details]
Patch
Created attachment 412715 [details]
Patch
Comment on attachment 412715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412715&action=review > Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:110 > +template<> struct EnumTraits<WebCore::ScrollingStateNode::Property> { > + using values = EnumValues< > + WebCore::ScrollingStateNode::Property, > + WebCore::ScrollingStateNode::Property::Layer, > + WebCore::ScrollingStateNode::Property::ChildNodes, > + WebCore::ScrollingStateNode::Property::ScrollableAreaSize, Sad that this thing has to list all values again. Does it at least fail at compile time if you miss something? (In reply to Antti Koivisto from comment #3) > Comment on attachment 412715 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412715&action=review > > > Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:110 > > +template<> struct EnumTraits<WebCore::ScrollingStateNode::Property> { > > + using values = EnumValues< > > + WebCore::ScrollingStateNode::Property, > > + WebCore::ScrollingStateNode::Property::Layer, > > + WebCore::ScrollingStateNode::Property::ChildNodes, > > + WebCore::ScrollingStateNode::Property::ScrollableAreaSize, > > Sad that this thing has to list all values again. Does it at least fail at > compile time if you miss something? It does compile but I assume IPC decoding would throw a failure at runtime. Not ideal. Committed r269184: <https://trac.webkit.org/changeset/269184> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412715 [details]. |