Bug 218373

Summary:

Remove all remaining testRunner.overridePreference calls

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, clopez, darin, ews-watchlist, simon.fraser, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none

Sam Weinig

Reported 2020-10-29 20:49:28 PDT

Remove all remaining testRunner.overridePreference calls

Attachments
Patch (20.83 KB, patch) 2020-10-29 20:55 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (20.84 KB, patch) 2020-10-29 21:04 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (21.43 KB, patch) 2020-10-30 08:06 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (20.80 KB, patch) 2020-10-30 09:31 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (20.59 KB, patch) 2020-10-30 12:08 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (25.10 KB, patch) 2020-10-30 17:03 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2020-10-29 20:55:02 PDT Comment hidden (obsolete)

Created attachment 412707 [details] Patch

Sam Weinig

Comment 2 2020-10-29 21:04:26 PDT Comment hidden (obsolete)

Created attachment 412709 [details] Patch

Sam Weinig

Comment 3 2020-10-30 08:06:31 PDT Comment hidden (obsolete)

Created attachment 412745 [details] Patch

EWS Watchlist

Comment 4 2020-10-30 08:13:04 PDT Comment hidden (obsolete)

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Sam Weinig

Comment 5 2020-10-30 09:31:07 PDT Comment hidden (obsolete)

Created attachment 412759 [details] Patch

Sam Weinig

Comment 6 2020-10-30 12:08:12 PDT

Created attachment 412785 [details] Patch

Sam Weinig

Comment 7 2020-10-30 17:03:33 PDT

Created attachment 412813 [details] Patch

Sam Weinig

Comment 8 2020-10-30 19:36:06 PDT

Ok. Should be good to go now if anyone wants to review.

EWS

Comment 9 2020-10-31 09:08:55 PDT

Committed r269226: <https://trac.webkit.org/changeset/269226> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412813 [details].

Radar WebKit Bug Importer

Comment 10 2020-10-31 09:09:25 PDT

<rdar://problem/70916397>

Darin Adler

Comment 11 2020-11-01 11:57:46 PST

Comment on attachment 412813 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412813&action=review Forgot to push "publish" when I wrote this comment! > LayoutTests/ChangeLog:46 > +2020-10-29 Sam Weinig <weinig@apple.com> > + > + > + * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: > + * fast/parser/noscript-with-javascript-disabled.html: > + * fast/text/international/locale-sensitive-fonts.html: > + * fast/text/zero-font-size.html: > + * http/tests/download/default-encoding.html: > + * http/tests/misc/favicon-loads-with-images-disabled.html: > + * http/tests/security/cross-origin-local-storage-wk1.html: > + * http/tests/security/resources/load-local-storage.html: > + * http/tests/xsl/xslt-transform-with-javascript-disabled.html: > + * platform/win/inverted-colors/non-composited.html: > + * platform/wk2/TestExpectations: > + * svg/as-image/svg-image-with-data-uri-images-disabled.html: Oops, extra change log stuff here.

Note You need to log in before you can comment on or make changes to this bug.