Bug 218355

Summary: Remove all remaining boolean overridePreference calls
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2020-10-29 14:06:58 PDT
Remove all remaining boolean overridePreference calls
Attachments
Patch (28.94 KB, patch)
2020-10-29 14:25 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (30.47 KB, patch)
2020-10-29 15:40 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-29 14:25:51 PDT
Created attachment 412686 [details] Patch
Sam Weinig
Comment 2 2020-10-29 15:40:02 PDT
Created attachment 412695 [details] Patch
Darin Adler
Comment 3 2020-10-29 15:46:34 PDT
Comment on attachment 412695 [details] Patch A lot of unneeded "window." prefixes in these tests. Once we know we’re running in a test runner, then "internals" works, and we don’t need "window.internals".
EWS
Comment 4 2020-10-29 18:17:34 PDT
Committed r269176: <https://trac.webkit.org/changeset/269176> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412695 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-29 18:18:22 PDT
<rdar://problem/70837130>
Note You need to log in before you can comment on or make changes to this bug.