Bug 218294

Summary: [MSE] Handle trackId changing across Initialization Segments
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218317
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Jer Noble 2020-10-28 10:48:46 PDT 
[MSE] Handle trackId changing across Initialization Segments
Comment 1 Radar WebKit Bug Importer 2020-10-28 11:02:41 PDT 
<rdar://problem/70771306>
Comment 2 Jer Noble 2020-10-28 11:02:53 PDT 
Created attachment 412546 [details]
Patch
Comment 3 Peng Liu 2020-10-28 11:25:23 PDT 
Comment on attachment 412546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412546&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1166
> +                }

Nit. There seems to be some duplicated code snippets, can we define a function for them?

> LayoutTests/media/media-source/media-source-trackid-change.html:66
> +            consoleWrite('Modify an Media Segment to have a different trackID');

Nit. s/an Media/a Media/
Comment 4 Jer Noble 2020-10-28 11:43:26 PDT 
(In reply to Peng Liu from comment #3)
> Comment on attachment 412546 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412546&action=review
> 
> > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1166
> > +                }
> 
> Nit. There seems to be some duplicated code snippets, can we define a
> function for them?

Not really as they're all different types.

> > LayoutTests/media/media-source/media-source-trackid-change.html:66
> > +            consoleWrite('Modify an Media Segment to have a different trackID');
> 
> Nit. s/an Media/a Media/

Will change.
Comment 5 Eric Carlson 2020-10-28 12:46:28 PDT 
Comment on attachment 412546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412546&action=review

> Source/WebCore/ChangeLog:5
> +

Nit: <rdar://problem/????>
Comment 6 Jer Noble 2020-10-28 12:54:33 PDT 
Created attachment 412563 [details]
Patch for landing
Comment 7 EWS 2020-10-28 13:43:12 PDT 
Committed r269121: <https://trac.webkit.org/changeset/269121>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412563 [details].