| Summary: | [Testing] Remove requirement of adding new SPI for each preference that needs testing (WebKitLegacy Windows) | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | bfulgham, Hironori.Fujii, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Sam Weinig
2020-10-28 09:57:15 PDT
Created attachment 412539 [details]
Patch
Created attachment 412541 [details]
Patch
Created attachment 412549 [details]
Patch
Created attachment 412559 [details]
Patch
Brent, any idea why the Apple Windows bot has this error: error C2039: 'setBoolPreferenceForTesting': is not a member of 'IWebPreferencesPrivate8. Is there something else I need to do to add functions to IWebPreferencesPrivate8 other than what I am doing? I don't see any problems with your code. I suspect we need to force a clean build because of some dependency issue in the Windows build. Comment on attachment 412559 [details]
Patch
r=me. The Windows build failure is not because of this change, but is a symptom of a dependency problem in the IDL generation on Windows. We may need to force a clean build once this lands.
Created attachment 412580 [details]
Patch
Created attachment 412600 [details]
Patch
Committed r269157: <https://trac.webkit.org/changeset/269157> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412600 [details]. Filed: Bug 220145 – [WinCairo][DumpRenderTree] Some JS tests are timing out only in Debug builds since r269157 |