Bug 218270

Summary: [GTK4] Build broken with GTK 3.99.3
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKitGTKAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: alicem, berto, bugs-noreply, cgarcia, clopez, ews-watchlist, gustavo, pnormand
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adrian Perez
Reported 2020-10-27 18:29:29 PDT
SSIA
Attachments
Patch (6.38 KB, patch)
2020-10-27 18:36 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.42 KB, patch)
2020-10-28 01:52 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2020-10-27 18:36:53 PDT
Created attachment 412495 [details] Patch
EWS Watchlist
Comment 2 2020-10-27 18:37:35 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alice Mikhaylenko
Comment 3 2020-10-28 00:16:01 PDT
*** Bug 218226 has been marked as a duplicate of this bug. ***
Carlos Garcia Campos
Comment 4 2020-10-28 01:06:16 PDT
Comment on attachment 412495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412495&action=review > Source/WebKit/UIProcess/Gamepad/gtk/UIGamepadProviderGtk.cpp:50 > + for (auto *child = gtk_widget_get_first_child(widget); child; child = gtk_widget_get_next_sibling(child)) { auto* child
Adrian Perez
Comment 5 2020-10-28 01:52:26 PDT
Created attachment 412512 [details] Patch for landing
EWS
Comment 6 2020-10-28 02:31:21 PDT
Committed r269096: <https://trac.webkit.org/changeset/269096> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412512 [details].
Note You need to log in before you can comment on or make changes to this bug.