Bug 218268

Summary: Unexpected txt file: .../WebKitLegacy.framework/.../Sources.txt
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, joepeck, keith_miller, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2020-10-27 17:55:15 PDT
Sources.txt and SourcesCocoa.txt were added to the WebKitLegacy project in https://trac.webkit.org/changeset/247401 as targets of the WebKitLegacy target. This caused them to be treated as resources and so were copied to the framework's Resources directory on a build. These files don't need to be included in the build, and so need to be removed from that target.
Attachments
Patch (3.33 KB, patch)
2020-10-27 18:07 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Rollin
Comment 1 2020-10-27 17:56:14 PDT
<rdar://problem/70742539>
Keith Rollin
Comment 2 2020-10-27 18:07:52 PDT
Created attachment 412489 [details] Patch
Tim Horton
Comment 3 2020-10-27 18:12:46 PDT
Does this leave them in the project? I think they should be in the project, just not a part of any target
Keith Rollin
Comment 4 2020-10-27 18:13:36 PDT
Yes, they're still in the project, so you can select and open them. They were merely removed from the target.
Keith Miller
Comment 5 2020-10-27 18:19:22 PDT
Seems reasonable to me.
Simon Fraser (smfr)
Comment 6 2020-10-27 18:20:47 PDT
Don't we have a script that checks for files added to frameworks by mistake? Why didn't it catch this?
Simon Fraser (smfr)
Comment 7 2020-10-27 18:22:48 PDT
"Check For Inappropriate Files In Framework"
Keith Rollin
Comment 8 2020-10-27 18:28:41 PDT
check-for-inappropriate-files-in-framework needs to be attached to WebKitLegacy (and JavaScriptCore) and updated to scan for *.txt files.
EWS
Comment 9 2020-10-27 19:26:01 PDT
Committed r269093: <https://trac.webkit.org/changeset/269093> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412489 [details].
Note You need to log in before you can comment on or make changes to this bug.