Bug 218264

Summary: Make RenderingMode a bool enum and remove ShouldAccelerate
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: CanvasAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217735    
Attachments:
Description Flags
Patch
none
Patch none

Said Abou-Hallawa
Reported 2020-10-27 15:41:38 PDT
The following four values are only used in one instance of ImageBuffer::create(): RenderingMode::DisplayListAccelerated, RenderingMode::DisplayListUnaccelerated, RenderingMode::RemoteAccelerated, RenderingMode::RemoteUnaccelerated Many places in the code convert from RenderingMode to ShouldAccelerate and vice versa. Also one of the WebChromeClient::createImageBuffer() always returns null since it does not override its virtual function in the base class ChromeClient. So RenderingMode is converted back to be a bool enum as it was before and ShouldAccelerate will be removed. No conversion is needed anymore. And only one instance of ImageBuffer::create() will be handling creating the remote and display list ImageBuffers.
Attachments
Patch (28.68 KB, patch)
2020-10-27 16:09 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (28.73 KB, patch)
2020-10-27 17:12 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-10-27 16:09:43 PDT
Created attachment 412474 [details] Patch
Said Abou-Hallawa
Comment 2 2020-10-27 17:12:00 PDT
Created attachment 412479 [details] Patch
EWS
Comment 3 2020-10-27 18:36:55 PDT
Committed r269084: <https://trac.webkit.org/changeset/269084> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412479 [details].
Radar WebKit Bug Importer
Comment 4 2020-10-27 18:37:28 PDT
<rdar://problem/70747549>
Note You need to log in before you can comment on or make changes to this bug.