Bug 218246

Summary: [GStreamer] Switch the ImageDecoder to decodebin3
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, ews-watchlist, gustavo, menard, tsaunier, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218245
Attachments:
Description Flags
Patch calvaris: review+

Philippe Normand
Reported 2020-10-27 10:43:03 PDT
See https://bugs.webkit.org/show_bug.cgi?id=218245
Attachments
Patch (5.83 KB, patch)
2020-10-30 06:04 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-10-30 06:04:13 PDT
Created attachment 412734 [details] Patch
Thibault Saunier
Comment 2 2020-10-30 06:19:08 PDT
Comment on attachment 412734 [details] Patch lgtm
Xabier Rodríguez Calvar
Comment 3 2020-11-02 05:07:04 PST
Comment on attachment 412734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412734&action=review > Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:229 > +int ImageDecoderGStreamer::InnerDecoder::decodebinSelectStreamCallback(GstElement*, GstStreamCollection*, GstStream* stream, ImageDecoderGStreamer::InnerDecoder* decoder) > +{ > + return decoder->selectStream(stream); > +} I would use a lambda instead of this. > Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:244 > + int result = (gst_stream_get_stream_type(stream) & GST_STREAM_TYPE_VIDEO) ? 1 : 0; You don't need the () around gst_stream_get_stream_type(stream) & GST_STREAM_TYPE_VIDEO
Philippe Normand
Comment 4 2020-11-16 01:28:22 PST
Committed r269839: <https://trac.webkit.org/changeset/269839>
Radar WebKit Bug Importer
Comment 5 2020-11-16 01:29:17 PST
<rdar://problem/71431266>
Note You need to log in before you can comment on or make changes to this bug.