Bug 218231

Summary:

[WPE] REGRESSION(r268992) Redefinition of min() inside TextureMapperShaderProgram for GLES > 3.0

Product:

WebKit

Reporter:

Miguel Gomez <magomez>

Component:

WPE WebKit

Assignee:

Miguel Gomez <magomez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, cmarcelo, ews-watchlist, kondapallykalyan, luiz, noam, svillar

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Miguel Gomez 2020-10-27 07:35:01 PDT

r268992 added a definition of the function min() inside the shader, as that function is not defined in GLES2. But when using GLES we don't check for the version, so the new function is defined for every version, causing an error when GLES is bigger than 3.0 and the function is already defined.

I'll go for the simpler path and remove the usage of the min function, so we don't need to add version checks when using GLES.

Comment 1 Miguel Gomez 2020-10-27 07:43:36 PDT

Created attachment 412419 [details]
Patch

Comment 2 EWS 2020-10-27 08:34:06 PDT

Committed r269040: <https://trac.webkit.org/changeset/269040>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412419 [details].