Bug 21822

Summary: Correct Windows (Cairo) Build
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch to correct Cairo build (Windows)
none
Patch to correct build issues in WebKit. oliver: review+

Description Brent Fulgham 2008-10-22 19:48:44 PDT 
I had mistakenly changed the stub ResourceRequest.h for Curl-based WebKit from my original dummy structure to a void*, believing that this worked just as well.  Unfortunately, I had not properly rebuilt, so my original structure-based implementation was still being used in the WebKit.dll build.

When I retrieved the updated sources with my 'new' change and rebuild, I found that WebKit.dll would not compile due to conflict between the definition in WebKit.h.

The attached patch returns to my original dummy structure, which satisfies the compiler dependencies set by the WebKit.idl interface.
Comment 1 Brent Fulgham 2008-10-22 20:04:42 PDT 
Created attachment 24587 [details]
Patch to correct Cairo build (Windows)
Comment 2 Brent Fulgham 2008-10-22 21:11:02 PDT 
Created attachment 24589 [details]
Patch to correct build issues in WebKit.
Comment 3 Sam Weinig 2008-10-23 13:36:59 PDT 
Landed in r37823.