Summary: | [EME][GStreamer] Decode base64 init data if needed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> | ||||||
Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | cgarcia, ews-watchlist, gustavo, menard, pnormand, vjaquez, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 218174 | ||||||||
Bug Blocks: | 218238 | ||||||||
Attachments: |
|
Description
Xabier Rodríguez Calvar
2020-10-26 04:13:10 PDT
Created attachment 412304 [details]
Patch
Comment on attachment 412304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 > + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file. (In reply to Philippe Normand from comment #2) > Comment on attachment 412304 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412304&action=review > > > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 > > + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); > > Seems like this would work only because of unified builds? Can you declare a > dedicated log category for this module and make it default? It would reduce > macro verbosity and also be useful for the GST_ERROR call in this file. This is a header file. Declaring a default category seems a bad idea, right? The build problem should be solved by landing patch for bug 218174 first. Comment on attachment 412304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review >>> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 >>> + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); >> >> Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file. > > This is a header file. Declaring a default category seems a bad idea, right? Not if you use GST_DEBUG_CATEGORY_EXTERN. Created attachment 412411 [details]
Patch
Committed r269033: <https://trac.webkit.org/changeset/269033> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412411 [details]. It looks this patch makes media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html timeout. I'm on it. Reverted r269033 for reason: 269043 Committed r269097: <https://trac.webkit.org/changeset/269097> This solution ain't good, I need to find another one. Reverted and closing. |