Summary: | Use a WeakHashSet for Document::m_captionPreferencesChangedElements | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | Media | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Local Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
youenn fablet
2020-10-26 02:52:00 PDT
Created attachment 412299 [details]
Patch
Created attachment 412305 [details]
Patch
Created attachment 412308 [details]
Patch
Created attachment 412313 [details]
Patch
Comment on attachment 412313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412313&action=review > Source/WTF/wtf/WeakHashSet.h:-142 > - for (auto& item : map(m_set, [](auto& item) { return makeWeakPtr(item->template get<T>()); })) { We need a static_cast here like weak hashset iterator is doing. I changed the code so that wincairo compiles it, which requires removal of some autos. Committed r268979: <https://trac.webkit.org/changeset/268979> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412313 [details]. |