Bug 218159

Summary:

JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Bindings

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, cdumez, darin, esprehn+autocc, ews-watchlist, jsbell, keith_miller, kondapallykalyan, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Sam Weinig

Reported 2020-10-25 09:43:55 PDT

JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage.

Attachments
Patch (233.57 KB, patch) 2020-10-25 09:49 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (233.50 KB, patch) 2020-10-25 14:00 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (234.08 KB, patch) 2020-10-25 14:27 PDT, Sam Weinig	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (233.93 KB, patch) 2020-10-25 14:34 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (233.69 KB, patch) 2020-10-25 18:23 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.