Bug 218155

Summary: [LFC Display] Implement background image painting
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Simon Fraser (smfr) 2020-10-24 15:53:03 PDT
[LFC Display] Implement background image painting
Comment 1 Simon Fraser (smfr) 2020-10-24 15:57:28 PDT
Created attachment 412251 [details]
Patch
Comment 2 Sam Weinig 2020-10-24 17:22:27 PDT
Comment on attachment 412251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412251&action=review

> Source/WebCore/display/css/DisplayFillLayerImageGeometry.h:48
> +    FillLayerImageGeometry()

What is this default constructor needed for? Can we remove it?

> Source/WebCore/display/css/DisplayFillLayerImageGeometry.h:53
> +    FillLayerImageGeometry(const FloatRect& destinationRect, const FloatSize& tileSize, const FloatSize& phase, const FloatSize& space, bool fixedAttachment)

Enum rather than a bool for fixedAttachment?
Comment 3 Simon Fraser (smfr) 2020-10-24 19:47:31 PDT
Created attachment 412257 [details]
Patch
Comment 4 EWS 2020-10-24 21:27:20 PDT
Committed r268955: <https://trac.webkit.org/changeset/268955>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412257 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-24 21:28:17 PDT
<rdar://problem/70655689>