Bug 218155

Summary: [LFC Display] Implement background image painting
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2020-10-24 15:53:03 PDT
[LFC Display] Implement background image painting
Attachments
Patch (52.38 KB, patch)
2020-10-24 15:57 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (52.29 KB, patch)
2020-10-24 19:47 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-10-24 15:57:28 PDT
Created attachment 412251 [details] Patch
Sam Weinig
Comment 2 2020-10-24 17:22:27 PDT
Comment on attachment 412251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412251&action=review > Source/WebCore/display/css/DisplayFillLayerImageGeometry.h:48 > + FillLayerImageGeometry() What is this default constructor needed for? Can we remove it? > Source/WebCore/display/css/DisplayFillLayerImageGeometry.h:53 > + FillLayerImageGeometry(const FloatRect& destinationRect, const FloatSize& tileSize, const FloatSize& phase, const FloatSize& space, bool fixedAttachment) Enum rather than a bool for fixedAttachment?
Simon Fraser (smfr)
Comment 3 2020-10-24 19:47:31 PDT
Created attachment 412257 [details] Patch
EWS
Comment 4 2020-10-24 21:27:20 PDT
Committed r268955: <https://trac.webkit.org/changeset/268955> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412257 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-24 21:28:17 PDT
<rdar://problem/70655689>
Note You need to log in before you can comment on or make changes to this bug.