Bug 218134

Summary:

[webkitscmpy] Assume default branch when no branch specified

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

NEW

Severity:

Normal

CC:

aakash_jain, dean_johnson, dewei_zhu, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=215862

Attachments:

Description	Flags
Patch	jbedard: review?

Jonathan Bedard

Reported 2020-10-23 13:00:45 PDT

Currently, if the most recent commit to SVN was not on the default branch, we will attempt to compute identifiers on that branch rather than the default branch. This is also true in Git, but less serious because this can only happen if the user has their checkout on that branch. I'm not entirely certain what we want the behavior here to be, but I'm fairly certain the current behavior is wrong.

Attachments
Patch (3.97 KB, patch) 2020-10-23 13:31 PDT, Jonathan Bedard	jbedard: review?	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-10-23 13:01:16 PDT

<rdar://problem/70631274>

Jonathan Bedard

Comment 2 2020-10-23 13:01:53 PDT

I think the correct behavior here is to always assume the default branch when no branch is specified, that way the script does not behave differently based on the state of the checkout.

Jonathan Bedard

Comment 3 2020-10-23 13:31:22 PDT

Created attachment 412208 [details] Patch

Jonathan Bedard

Comment 4 2020-11-11 16:35:39 PST

After working on https://bugs.webkit.org/show_bug.cgi?id=218827, I'm quite convinced we should land this change.

Note You need to log in before you can comment on or make changes to this bug.