Bug 21813

Summary:

Enable custom properties for runtime objects in QtWebKit

Product:

WebKit

Reporter:

jade han <jade.han>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, hausmann, vestbo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
This patch implements the feature	none
patch that limits behavior to QtInstance, and also expands the autotest for custom properties	none
similar to previous patch (limits to QtInstance), but removes debug statement	andersca: review+

jade han

Reported 2008-10-22 15:42:36 PDT

Enabling custom properties for runtime objects allows us to do myNativeRuntimeObject.foo = "bar", which can be useful.

Attachments
This patch implements the feature (1.93 KB, patch) 2008-10-22 15:44 PDT, jade han	no flags	Details Formatted Diff Diff
patch that limits behavior to QtInstance, and also expands the autotest for custom properties (2.61 KB, patch) 2008-10-23 06:59 PDT, jade han	no flags	Details Formatted Diff Diff
similar to previous patch (limits to QtInstance), but removes debug statement (2.59 KB, patch) 2008-10-23 07:01 PDT, jade han	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

jade han

Comment 1 2008-10-22 15:44:17 PDT

Created attachment 24576 [details] This patch implements the feature

Anders Carlsson

Comment 2 2008-10-22 17:48:29 PDT

Comment on attachment 24576 [details] This patch implements the feature Are you sure you want to do this for all runtime objects and not just QtInstances? Neither WebKit nor Firefox support setting custom properties on NPObjects for example.

jade han

Comment 3 2008-10-23 06:57:01 PDT

You're right Anders, I will make a new patch that limits this behavior to QtInstance.

jade han

Comment 4 2008-10-23 06:59:27 PDT

Created attachment 24597 [details] patch that limits behavior to QtInstance, and also expands the autotest for custom properties

jade han

Comment 5 2008-10-23 07:01:44 PDT

Created attachment 24598 [details] similar to previous patch (limits to QtInstance), but removes debug statement

Anders Carlsson

Comment 6 2008-10-23 09:04:50 PDT

Comment on attachment 24598 [details] similar to previous patch (limits to QtInstance), but removes debug statement Looks great! r=me

Tor Arne Vestbø

Comment 7 2008-10-25 08:24:13 PDT

Thanks for the review Anders! Landed in r37889

Note You need to log in before you can comment on or make changes to this bug.