Bug 218088 – [css-logical] Add support for block/inline CSS values for resize property

• Component: CSS
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Add logical values for 'resize'
https://drafts.csswg.org/css-ui/#resize

[Radar WebKit Bug Importer]

<rdar://problem/70578888>

[Tim Nguyen (:ntim)]

Created attachment 456342 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 456342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review

> Source/WebCore/css/CSSProperties.json:-4267
> -            "inherited": true,

Not sure why this was set, but Resize was in StyleRare_Non_InheritedData.h, and per-spec it shouldn't be inherited anyway.

[Antti Koivisto]

Comment on attachment 456342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2791
> +    canResizeWidth |= resize == Resize::Horizontal || resize == Resize::Both;

Not a fan of using bitwise operators for boolean logic.

[Tim Nguyen (:ntim)]

Created attachment 456343 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 456345 [details]
Patch

[EWS]

Committed r292222 (249125@main): <https://commits.webkit.org/249125@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456345 [details].