Bug 218084

Summary:

Use operand names when dumping Bytecode

Product:

WebKit

Reporter:

Robin Morisset <rmorisset>

Component:

JavaScriptCore

Assignee:

Robin Morisset <rmorisset>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Robin Morisset 2020-10-22 09:05:42 PDT

It can sometimes be tricky to read dumped bytecode, especially for ops with lots of operands. Thankfully, we have names for each of them. I am just proposing putting them in the dumping format.

Comment 1 Robin Morisset 2020-10-22 09:09:00 PDT

Created attachment 412103 [details]
Patch

Comment 2 Saam Barati 2020-10-22 10:00:29 PDT

Comment on attachment 412103 [details]
Patch

nice

Comment 3 EWS 2020-10-22 10:45:58 PDT

Committed r268871: <https://trac.webkit.org/changeset/268871>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412103 [details].

Comment 4 Radar WebKit Bug Importer 2020-10-22 10:46:24 PDT

<rdar://problem/70579826>