Bug 218075

Summary: Rename scroll-snap-margin to scroll-margin
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: CSSAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, cmarcelo, dev, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jamesr, joepeck, kondapallykalyan, luiz, macpherson, menard, pdr, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 189265    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Martin Robinson 2020-10-22 03:43:04 PDT 
This is one part of updating the implementation of scroll-snap-margin to match the most recent CSS Scroll Snap specification. See: https://drafts.csswg.org/css-scroll-snap-1/#scroll-margin
Comment 1 Martin Robinson 2020-10-22 06:31:53 PDT 
Created attachment 412091 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-10-22 07:18:43 PDT 
Looks like you have some tests to fix.
Comment 3 Martin Robinson 2020-10-22 08:11:29 PDT 
Created attachment 412097 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-10-22 08:43:08 PDT 
Comment on attachment 412097 [details]
Patch

r=me with the caveat that if we see compat issues we might have to bring the old names back.
Comment 5 Martin Robinson 2020-10-22 09:50:42 PDT 
Thanks for the review! I guess I should mention, in case it changes your feelings about the change, that this patch maintains the old names as aliases. I will fix the failing ios test and try to land this tomorrow.
Comment 6 Martin Robinson 2020-10-22 10:30:53 PDT 
Created attachment 412112 [details]
Patch
Comment 7 EWS 2020-10-22 13:31:53 PDT 
Committed r268889: <https://trac.webkit.org/changeset/268889>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412112 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-22 13:32:53 PDT 
<rdar://problem/70587063>