Bug 218072

Summary:

[JSC] Enable bytecode cache testing in stress tests for Linux

Product:

WebKit

Reporter:

Xan Lopez <xan.lopez>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

smoley, xan.lopez, ysuzuki

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Enable bytecode cache testing on Linux, v1	none
Enable bytecode cache testing on Linux, v2	none
Enable bytecode cache testing on Linux, v3	none
Enable bytecode cache testing on Linux, v4	none

Xan Lopez

Reported 2020-10-22 01:55:26 PDT

The script was only doing this for Darwin, but it can also work on Linux (possibly others, leaving that aside for now) with a trivial change.

Attachments
Enable bytecode cache testing on Linux, v1 (3.67 KB, patch) 2020-10-22 01:58 PDT, Xan Lopez	no flags	Details Formatted Diff Diff
Enable bytecode cache testing on Linux, v2 (3.64 KB, patch) 2020-10-22 02:02 PDT, Xan Lopez	no flags	Details Formatted Diff Diff
Enable bytecode cache testing on Linux, v3 (4.16 KB, patch) 2020-11-06 01:05 PST, Xan Lopez	no flags	Details Formatted Diff Diff
Enable bytecode cache testing on Linux, v4 (4.76 KB, patch) 2020-11-09 03:56 PST, Xan Lopez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Xan Lopez

Comment 1 2020-10-22 01:58:13 PDT

Created attachment 412074 [details] Enable bytecode cache testing on Linux, v1

Xan Lopez

Comment 2 2020-10-22 02:02:21 PDT

Created attachment 412075 [details] Enable bytecode cache testing on Linux, v2 v2, use proper indentation on the ruby script

Xan Lopez

Comment 3 2020-10-22 07:25:02 PDT

Nice, this seemingly uncovers a lot of failures in bytecode cache tests for armv7 and mips (almost the same number of failures). I'll see if this also applies to x86_64 to decide what to do next.

Xan Lopez

Comment 4 2020-10-29 09:18:41 PDT

(In reply to Xan Lopez from comment #3) > Nice, this seemingly uncovers a lot of failures in bytecode cache tests for > armv7 and mips (almost the same number of failures). I'll see if this also > applies to x86_64 to decide what to do next. This does not happen in x86_64, either Release or Debug.

Xan Lopez

Comment 5 2020-11-06 01:05:09 PST

Created attachment 413412 [details] Enable bytecode cache testing on Linux, v3 v3, do not use arrays in the shell script, that way it will work in any POSIX shell. This was the error in some of the EWS bots in the end (which use 'dash').

Xan Lopez

Comment 6 2020-11-09 03:56:32 PST

Created attachment 413579 [details] Enable bytecode cache testing on Linux, v4 v4, skip on MIPS until bug #218703 is fixed and we make the bots a bit faster.

Yusuke Suzuki

Comment 7 2020-11-09 15:28:42 PST

Comment on attachment 413579 [details] Enable bytecode cache testing on Linux, v4 r=me

EWS

Comment 8 2020-11-09 15:41:00 PST

Committed r269608: <https://trac.webkit.org/changeset/269608> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413579 [details].

Note You need to log in before you can comment on or make changes to this bug.