Bug 218048

Summary:

Update FFTFrame::realData() / imagData() to return an AudioFloatArray

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Web Audio

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, pnormand, rs, sam, sergio, vjaquez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

217890

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none

Description Chris Dumez 2020-10-21 13:22:00 PDT

Update FFTFrame::realData() / imagData() to return an AudioFloatArray instead of a float*. This is necessary because only the implementation of FFTFrame knew the actual size of the arrays returned. Cocoa ports use fftSize() as size for these arrays for the port using GStreamer don't.

Comment 1 Chris Dumez 2020-10-21 13:43:47 PDT

Created attachment 412024 [details]
Patch

Comment 2 Chris Dumez 2020-10-21 13:49:20 PDT

Created attachment 412028 [details]
Patch

Comment 3 Philippe Normand 2020-10-21 14:26:44 PDT

Comment on attachment 412028 [details]
Patch

Thanks for the patch Chris, I suspect this might fix a few other crashes in layout tests :)

Comment 4 EWS 2020-10-21 14:33:10 PDT

Committed r268826: <https://trac.webkit.org/changeset/268826>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412028 [details].

Comment 5 Radar WebKit Bug Importer 2020-10-21 14:34:20 PDT

<rdar://problem/70545640>

Comment 6 David Kilzer (:ddkilzer) 2020-11-03 14:08:57 PST

*** Bug 217890 has been marked as a duplicate of this bug. ***