Bug 218048 - Update FFTFrame::realData() / imagData() to return an AudioFloatArray
Summary: Update FFTFrame::realData() / imagData() to return an AudioFloatArray
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
: 217890 (view as bug list)
Depends on:
Blocks: 217890
  Show dependency treegraph
Reported: 2020-10-21 13:22 PDT by Chris Dumez
Modified: 2020-11-03 14:08 PST (History)
15 users (show)

See Also:

Patch (14.67 KB, patch)
2020-10-21 13:43 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.68 KB, patch)
2020-10-21 13:49 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-21 13:22:00 PDT
Update FFTFrame::realData() / imagData() to return an AudioFloatArray instead of a float*. This is necessary because only the implementation of FFTFrame knew the actual size of the arrays returned. Cocoa ports use fftSize() as size for these arrays for the port using GStreamer don't.
Comment 1 Chris Dumez 2020-10-21 13:43:47 PDT
Created attachment 412024 [details]
Comment 2 Chris Dumez 2020-10-21 13:49:20 PDT
Created attachment 412028 [details]
Comment 3 Philippe Normand 2020-10-21 14:26:44 PDT
Comment on attachment 412028 [details]

Thanks for the patch Chris, I suspect this might fix a few other crashes in layout tests :)
Comment 4 EWS 2020-10-21 14:33:10 PDT
Committed r268826: <https://trac.webkit.org/changeset/268826>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412028 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-21 14:34:20 PDT
Comment 6 David Kilzer (:ddkilzer) 2020-11-03 14:08:57 PST
*** Bug 217890 has been marked as a duplicate of this bug. ***