Bug 218017

Summary: [LFC][Integration] Update style of contained layout boxes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, jbedard, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
for bots
none
patch
zalan: review+
patch
ews-feeder: commit-queue-
followup none

Antti Koivisto
Reported 2020-10-21 05:45:58 PDT
Need to integrate style updates.
Attachments
patch (19.57 KB, patch)
2020-10-21 05:50 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
for bots (19.76 KB, patch)
2020-10-21 07:02 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (29.65 KB, patch)
2020-10-21 07:59 PDT, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (29.64 KB, patch)
2020-10-21 08:30 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
followup (1.43 KB, patch)
2020-10-21 12:01 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-10-21 05:50:25 PDT
Created attachment 411976 [details] patch
Antti Koivisto
Comment 2 2020-10-21 07:02:33 PDT
Created attachment 411981 [details] for bots
Antti Koivisto
Comment 3 2020-10-21 07:59:28 PDT
Created attachment 411984 [details] patch
zalan
Comment 4 2020-10-21 08:28:05 PDT
Comment on attachment 411984 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=411984&action=review > Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:71 > + mutable HashMap<const RenderObject*, Layout::Box*> m_rendererToBoxMap; > + mutable HashMap<const Layout::Box*, RenderObject*> m_boxToRendererMap; probably not need to be mutable anymore, as discussed in slack.
Antti Koivisto
Comment 5 2020-10-21 08:30:33 PDT
Created attachment 411988 [details] patch
EWS
Comment 6 2020-10-21 09:21:09 PDT
Committed r268798: <https://trac.webkit.org/changeset/268798> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411988 [details].
Radar WebKit Bug Importer
Comment 7 2020-10-21 09:22:21 PDT
<rdar://problem/70531938>
Antti Koivisto
Comment 8 2020-10-21 11:58:48 PDT
Followup
Antti Koivisto
Comment 9 2020-10-21 12:01:29 PDT
Created attachment 412013 [details] followup
EWS
Comment 10 2020-10-21 12:34:09 PDT
Committed r268818: <https://trac.webkit.org/changeset/268818> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412013 [details].
Carlos Alberto Lopez Perez
Comment 11 2020-10-21 18:12:57 PDT
Committed r268850: <https://trac.webkit.org/changeset/268850>
Carlos Alberto Lopez Perez
Comment 12 2020-10-21 18:15:45 PDT
The GTK stable builders build without experimental features enabled and LFC is only enabled when experimental features are enabled, thus it broke those builders. Example: https://build.webkit.org/builders/GTK-Linux-64-bit-Release-Debian-Stable-Build/builds/38728/steps/compile-webkit/logs/stdio So I landed the build-fix below for !ENABLE_LAYOUT_FORMATTING_CONTEXT (In reply to Carlos Alberto Lopez Perez from comment #11) > Committed r268850: <https://trac.webkit.org/changeset/268850>
Note You need to log in before you can comment on or make changes to this bug.