Bug 217998

Summary:

Web Inspector: Change minimum width of #tab-browser to a more reasonable value

Product:

WebKit

Reporter:

Patrick Angle <pangle>

Component:

Web Inspector

Assignee:

Patrick Angle <pangle>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Screenshot before patch	none
Patch	none
Screenshot after patch	none
Sidebar resizing (docked bottom) after patch	none
Sidebar resizing (docked side) after patch	none

Patrick Angle

Reported 2020-10-20 15:54:12 PDT

Created attachment 411930 [details] Screenshot before patch Currently the #tab-browser portion (for example the DOM Tree of the Elements Tab) has a minimum width of 100px. With the work done in b217396, it is now even easier to find this minimum width, and this minimum width is too small in almost all cases.

Attachments
Screenshot before patch (539.44 KB, image/png) 2020-10-20 15:54 PDT, Patrick Angle	no flags	Details
Patch (3.80 KB, patch) 2020-10-23 07:48 PDT, Patrick Angle	no flags	Details Formatted Diff Diff
Screenshot after patch (661.67 KB, image/png) 2020-10-23 07:49 PDT, Patrick Angle	no flags	Details
Sidebar resizing (docked bottom) after patch (23.60 MB, video/quicktime) 2020-10-23 07:49 PDT, Patrick Angle	no flags	Details
Sidebar resizing (docked side) after patch (30.76 MB, video/quicktime) 2020-10-23 07:50 PDT, Patrick Angle	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Patrick Angle

Comment 1 2020-10-23 07:48:26 PDT

Created attachment 412173 [details] Patch

Patrick Angle

Comment 2 2020-10-23 07:49:10 PDT

Created attachment 412174 [details] Screenshot after patch

Patrick Angle

Comment 3 2020-10-23 07:49:54 PDT

Created attachment 412175 [details] Sidebar resizing (docked bottom) after patch

Patrick Angle

Comment 4 2020-10-23 07:50:09 PDT

Created attachment 412176 [details] Sidebar resizing (docked side) after patch

Blaze Burg

Comment 5 2020-10-23 08:24:15 PDT

Comment on attachment 412173 [details] Patch r=me, this looks so much better than before. I have a slight concern that it's hard to make the main content area really big by resizing the window itself, but I think that will be addressed by adding a toggle for showing >1 sidebar pane.

EWS

Comment 6 2020-10-26 10:25:28 PDT

Committed r268981: <https://trac.webkit.org/changeset/268981> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412173 [details].

Radar WebKit Bug Importer

Comment 7 2020-10-26 10:26:29 PDT

<rdar://problem/70684444>

Note You need to log in before you can comment on or make changes to this bug.