Bug 217998 - Web Inspector: Change minimum width of #tab-browser to a more reasonable value
Summary: Web Inspector: Change minimum width of #tab-browser to a more reasonable value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-20 15:54 PDT by Patrick Angle
Modified: 2020-10-26 10:26 PDT (History)
6 users (show)

See Also:


Attachments
Screenshot before patch (539.44 KB, image/png)
2020-10-20 15:54 PDT, Patrick Angle
no flags Details
Patch (3.80 KB, patch)
2020-10-23 07:48 PDT, Patrick Angle
no flags Details | Formatted Diff | Diff
Screenshot after patch (661.67 KB, image/png)
2020-10-23 07:49 PDT, Patrick Angle
no flags Details
Sidebar resizing (docked bottom) after patch (23.60 MB, video/quicktime)
2020-10-23 07:49 PDT, Patrick Angle
no flags Details
Sidebar resizing (docked side) after patch (30.76 MB, video/quicktime)
2020-10-23 07:50 PDT, Patrick Angle
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2020-10-20 15:54:12 PDT
Created attachment 411930 [details]
Screenshot before patch

Currently the #tab-browser portion (for example the DOM Tree of the Elements Tab) has a minimum width of 100px. With the work done in b217396, it is now even easier to find this minimum width, and this minimum width is too small in almost all cases.
Comment 1 Patrick Angle 2020-10-23 07:48:26 PDT
Created attachment 412173 [details]
Patch
Comment 2 Patrick Angle 2020-10-23 07:49:10 PDT
Created attachment 412174 [details]
Screenshot after patch
Comment 3 Patrick Angle 2020-10-23 07:49:54 PDT
Created attachment 412175 [details]
Sidebar resizing (docked bottom) after patch
Comment 4 Patrick Angle 2020-10-23 07:50:09 PDT
Created attachment 412176 [details]
Sidebar resizing (docked side) after patch
Comment 5 BJ Burg 2020-10-23 08:24:15 PDT
Comment on attachment 412173 [details]
Patch

r=me, this looks so much better than before. I have a slight concern that it's hard to make the main content area really big by resizing the window itself, but I think that will be addressed by adding a toggle for showing >1 sidebar pane.
Comment 6 EWS 2020-10-26 10:25:28 PDT
Committed r268981: <https://trac.webkit.org/changeset/268981>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412173 [details].
Comment 7 Radar WebKit Bug Importer 2020-10-26 10:26:29 PDT
<rdar://problem/70684444>